Repository navigation
fix(band): count a test run only when the runner is the command - #1397
Open
daviorlando wants to merge 1 commit into
Open
daviorlando wants to merge 1 commit into
daviorlando wants to merge 1 commit into
Conversation
TEST_CMD matched anywhere in the line, so `cat jest.config.js`, `pip install pytest` or `grep -r vitest src` set the band's tests to pass with no counts, overwriting a real failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runner now has to be in command position:
;,&,|,(or a path;run,exec,npx,bunx,pnpx,time,env,nice,timeout N, orVAR=value.It must also not be followed by
.,-or a word character. Souv run pytest,CI=1 npx vitest run,./node_modules/.bin/jest,cd api && python -m pytestandbundle exec rspecstill count, and the commands in the issue no longer do.Added these cases to
tests/band.test.tsx. I can't run that file outside Claude Code (it importsclaude-code/testing), so I loaded the realmetrics.tsin Node 24 and checked the same cases plus about 30 more, before and after the change.npm test,check-rule-copiesandcheck-versionspass. The only failure is the pandas CSV case, which fails because pandas isn't installed locally, same as onmain.Fixes #1396
🤖 Generated with Claude Code