Repository navigation
fix(hooks): hide the console window of /ponytail band import on Windows - #1393
Open
daviorlando wants to merge 1 commit into
Open
daviorlando wants to merge 1 commit into
daviorlando wants to merge 1 commit into
Conversation
A detached child gets its own console window on Windows unless windowsHide is set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
windowsHide: trueto the detached spawn of the band import. It does nothing on other platforms.npm test,check-rule-copiesandcheck-versionspass. The only failure is the pandas CSV case, which fails because pandas isn't installed locally, same as onmain. I have no Windows machine, so I haven't seen the window disappear myself. The fix follows Node's documentedwindowsHidebehaviour for detached children.Fixes #1392
🤖 Generated with Claude Code