Repository navigation
fix(tests): make transcript lookup fixtures portable on Windows - #1386
Open
dungartoriaaa wants to merge 1 commit into
Open
dungartoriaaa wants to merge 1 commit into
dungartoriaaa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1375. Complements #1377.
Test tìm transcript không khớp fixture POSIX khi engine trên Windows đưa đường dẫn dạng
D:\home\u\.claude\projects\.... Vì vậyfs.existsvàfs.listtrả dữ liệu rỗng, test không đọc được tên hội thoại.Bản sửa chỉ nằm trong test
the transcript is found with no classic hook, in its named folder or any other. Các mock tìm tiêu đề và liệt kê thư mục so sánh phần cuối đường dẫn sau khi chuẩn hóa dấu phân cách. Assertion xác nhận không quét thư mục ở lần tìm đầu cũng xử lý phần drive trên Windows. Test vẫn kiểm tra đủ ba tình huống có sẵn gồm thư mục dự kiến, chuyển transcript sang worktree và đổi session.PR #1377 xử lý bốn test khác về cờ band/mode. Diff này chỉ chạm test transcript còn lại và áp dụng sạch cùng #1377.
Kiểm thử
npm testđạt 144 kiểm thử gốc và 30 kiểm thử pi.node scripts/check-rule-copies.jsđạt.node scripts/check-versions.jsđạt.python benchmarks/agentic/run.py --selftestđạt.claude plugin test .trên Windows, Claude Code 2.1.319, đạt 28/32. Bản gốc đạt 27/32. Test transcript chuyển từ lỗi sang đạt. Bốn lỗi còn lại đúng là bốn test thuộc fix(band): compare the end of the flag path in the band tests #1377.claude plugin test .trên Linux x64, Ubuntu 24.04 qua WSL và Claude Code 2.1.319, đạt 32/32 với riêng bản sửa này.English summary
Fix only the remaining transcript lookup test from #1375. Windows fs events normalize the fixture's POSIX paths to drive-prefixed backslash paths. Match their normalized suffixes in the file and directory mocks, and make the named-folder assertion use the same comparison. Preserve the existing named-folder, moved-worktree and new-session scenarios.
This is independent of #1377, which changes the other four failing tests. Verified on Claude Code 2.1.319 with 28/32 band tests passing on Windows (the other four belong to #1377), 32/32 on Linux, and 32/32 on Windows when combined with #1377. All required contribution checks pass.