feat: upgrade to @sentry/browser 8
#467
Conversation
There was a problem hiding this comment.
Figuring out how to fix some tests here still ...
There was a problem hiding this comment.
Not familiar with this sentry-testkit thing but it seems that whilst all tests pass individually, when the whole suite runs they conflict with each other as testkit.reports contains data from other tests.
@spawnia would you know anything about that?
There was a problem hiding this comment.
It appears that their API has not changed, see https://zivl.github.io/sentry-testkit/docs/getting-started#reset-between-tests. Perhaps we need to upgrade to the latest version, see https://github.com/zivl/sentry-testkit/tags?
There was a problem hiding this comment.
Yea that was the first place I looked. I tried it locally, as it did not have an effect I did not commit it.
There was a problem hiding this comment.
I have no other ideas. Let me know when you have a fix.
There was a problem hiding this comment.
I filed an issue with them zivl/sentry-testkit#200
I assume that is the problem
spawnia
changed the title
@sentry/browser:^8.0.0 as peer dependency@sentry/browser 8
tests/SentryLink.test.ts
Outdated
| }); | ||
| const scope = Sentry.getCurrentScope(); | ||
|
|
||
| scope.clearBreadcrumbs(); |
There was a problem hiding this comment.
The addBreadcrumb function adds breadcrumbs to the isolation scope so you'll need clear them from there instead
Sentry.getIsolationScope().clearBreadcrumbs();
There was a problem hiding this comment.
Well that was non-obvious, but seems to fix the tests, nice
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #466
https://docs.sentry.io/platforms/javascript/migration/v7-to-v8/#removal-of-sentryconfigurescope-method