fix: Improve watch command handling after closure #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update enables handling multiple watch commands for the same client after closing a previous watch connection. - Added IsClosed() method to all wire interfaces for connection state checks - Fixed watch connection handling to properly terminate watch loops - Added context support to TCPWire for graceful read interruption - Implemented CloseWatch() to properly close watch connections - Fixed IPv6 address handling with net.JoinHostPort - Improved error messages and code organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running other watch command after killing first watch does not work
This update enables handling multiple watch commands for the same client after closing a previous watch connection.
Related PR: DiceDB/dice#1738