Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tools for ssx and I19 #123

Merged
merged 58 commits into from
Jul 11, 2023
Merged

Refactor tools for ssx and I19 #123

merged 58 commits into from
Jul 11, 2023

Conversation

noemifrisina
Copy link
Collaborator

@noemifrisina noemifrisina commented Jun 27, 2023

Closes #115
Closes #55
Part of #57

  • Refactor SSX using new tools
  • Refactor I19 writer using new tools
  • Remove obsolete writers
  • Add a couple of tests
  • Tidy up

@noemifrisina noemifrisina added the refactoring Refactor parts of the code base label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #123 (d743741) into main (02f495a) will increase coverage by 2.76%.
The diff coverage is 39.36%.

❗ Current head d743741 differs from pull request most recent head 5bffd61. Consider uploading reports for the commit 5bffd61 to get more accurate results

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   34.17%   36.94%   +2.76%     
==========================================
  Files          42       43       +1     
  Lines        4041     4028      -13     
  Branches      826      796      -30     
==========================================
+ Hits         1381     1488     +107     
+ Misses       2529     2408     -121     
- Partials      131      132       +1     
Impacted Files Coverage Δ
src/nexgen/beamlines/I19_2_gda_nxs.py 0.00% <0.00%> (ø)
src/nexgen/beamlines/I19_2_nxs.py 0.00% <0.00%> (ø)
src/nexgen/beamlines/SSX_Eiger_nxs.py 0.00% <0.00%> (ø)
src/nexgen/beamlines/SSX_Tristan_nxs.py 0.00% <0.00%> (ø)
src/nexgen/command_line/ED_nexus.py 0.00% <0.00%> (ø)
src/nexgen/command_line/cli_utils.py 0.00% <0.00%> (ø)
src/nexgen/command_line/nexus_generator.py 0.00% <0.00%> (ø)
src/nexgen/nxs_write/NXmxWriter.py 0.00% <0.00%> (ø)
src/nexgen/nxs_copy/__init__.py 34.16% <23.52%> (+0.25%) ⬆️
src/nexgen/nxs_write/EDNexusWriter.py 34.09% <33.33%> (-2.28%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@noemifrisina noemifrisina changed the title Refactoring part 2 Refactor beamline tools Jul 10, 2023
@noemifrisina noemifrisina changed the title Refactor beamline tools Refactor tools for ssx and I19 Jul 10, 2023
@noemifrisina noemifrisina added Tristan Tristan detector related SSX Serial crystallography related labels Jul 11, 2023
@noemifrisina noemifrisina merged commit a1e67fb into main Jul 11, 2023
@noemifrisina noemifrisina deleted the refactoring-part-2 branch July 11, 2023 10:56
@noemifrisina noemifrisina restored the refactoring-part-2 branch July 20, 2023 20:05
@noemifrisina noemifrisina deleted the refactoring-part-2 branch July 20, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor parts of the code base SSX Serial crystallography related Tristan Tristan detector related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axis definition improvement Fix image number calculation for grid scans
1 participant