Fixes and updates#7
Open
PlantDaddy wants to merge 1 commit intoDheerendraRathor:masterfrom
Open
Conversation
…aught and could occur if the metadata says the framerate is '0/0' Added a new class called FFContainer that can be used to utilize to capture info about the container itself versus the stream. Added a function to FFProbe to break out the calling of ffprobe so future development/changes could call ffprobe with new arguments in certain cases. I also added type hinting to help with development of this and usage of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught an exception in the framerate call as ZeroDivionError wasn't caught and could occur if the metadata says the framerate is '0/0'
Added a new class called FFContainer that can be used to utilize to capture info about the container itself versus the stream.
Added a function to FFProbe to break out the calling of ffprobe so future development/changes could call ffprobe with new arguments in certain cases.
I also added type hinting to help with development of this and usage of this.