Skip to content

Fix GitHub cloud backup OAuth configuration - #4484

Merged
Marc-André Moreau (mamoreau-devolutions) merged 1 commit into
mainfrom
github-app-oauth
Mar 16, 2026
Merged

Marc-André Moreau (mamoreau-devolutions) merged 1 commit into
mainfrom
github-app-oauth

Conversation

@mamoreau-devolutions

@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor
  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

This fixes the GitHub cloud backup login break introduced during the repository migration.

Changes included:

  • wire the OAuth client ID and secret into the release workflow using the normalized UNIGETUI_GITHUB_* secret names
  • fail early in CI when those secrets are missing
  • harden the GitHub login flow so it fails clearly when OAuth credentials are unset or the loopback callback never arrives
  • update the affected login/backup help and privacy links away from the old marticliment.com targets

Validation:

  • dotnet build d:/dev/unigetui-github-app/src/UniGetUI/UniGetUI.csproj -p:Platform=x64 -p:Configuration=Debug -nologo -v minimal

Manual OAuth end-to-end validation still requires a valid GitHub OAuth app client ID and secret.

image image

Closes #4461

@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) merged commit 2265e17 into main Mar 16, 2026
5 checks passed
@TPS TPS mentioned this pull request Jun 2, 2026
4 tasks done
@TPS

TPS commented Jun 2, 2026

Copy link
Copy Markdown

#4788 reports that this still isn't working.…

This branch was previously deployed

1 inactive deployment
publish-test — 1ea2c0e9 Deployed Mar 16, 2026 by mamoreau-devolutions via Build & Sign (x64) #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Log in/Account section is broken

3 participants