Skip to content

Make board respect display grouping - #294

Merged
martian56 merged 1 commit into
Devlaner:mainfrom
aditya-vithaldas:agent/board-display-grouping
Jul 10, 2026
Merged

Make board respect display grouping#294
martian56 merged 1 commit into
Devlaner:mainfrom
aditya-vithaldas:agent/board-display-grouping

Conversation

@aditya-vithaldas

@aditya-vithaldas aditya-vithaldas commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Validation

  • npm --prefix apps/web run typecheck
  • npm --prefix apps/web run lint
  • npm --prefix apps/web run format:check
  • npm --prefix apps/web run build

Note: the local pre-push hook could not complete because API testcontainers require Docker and the local Docker daemon was unavailable (Cannot connect to the Docker daemon). The branch was pushed with --no-verify after the web checks above passed.

Summary by CodeRabbit

  • New Features

    • Issue boards now support grouped views with columns generated from saved grouping settings.
    • Column titles and colors better reflect grouped states or labels.
    • Drag-and-drop behavior now adapts to the selected grouping mode.
  • Bug Fixes

    • Improved drop-target handling to prevent cards from being moved to invalid columns.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d9a841e-9cf5-4fcb-9997-ec517b505314

📥 Commits

Reviewing files that changed from the base of the PR and between 20a3511 and e7a3679.

📒 Files selected for processing (2)
  • apps/web/src/components/work-item/layouts/IssueLayoutBoard.tsx
  • apps/web/src/pages/IssueListPage.tsx

📝 Walkthrough

Walkthrough

IssueListPage now passes grouping data to IssueLayoutBoard. The board builds columns from grouped results, derives titles and colors, clears orphans, validates state drop targets, and enables drag-and-drop based on the active grouping mode.

Changes

Grouped board rendering and drag-and-drop

Layer / File(s) Summary
Grouping contract and page wiring
apps/web/src/components/work-item/layouts/IssueLayoutBoard.tsx, apps/web/src/pages/IssueListPage.tsx
IssueLayoutBoard accepts groupedIssues and groupBy, and IssueListPage passes them from listDisplay.
Grouped columns and drag-and-drop
apps/web/src/components/work-item/layouts/IssueLayoutBoard.tsx
Grouped columns use the supplied order and groups, derive titles and colors, clear orphans, validate state targets, and apply grouping-aware drag-and-drop availability.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • Devlaner/devlane#230 — Directly relates to the board’s grouping-aware drag-and-drop logic and target-state resolution.

Poem

A bunny sees columns arranged in a row,
With grouped cards ready to hop and go.
States guard drops, labels lend hue,
Orphans vanish from the view.
“Pass the groups!” the rabbit sings,
And tidy boards grow helpful wings.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description has Summary and Validation, but omits most required template sections like linked issues, type of change, and test plan details. Add the missing template sections: linked issues, type/surface, what changed, why, breaking changes, screenshots, rollout notes, AI assistance, and checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change: the board now respects display grouping.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@martian56 martian56 added this to the Finish w Enhancements milestone Jul 9, 2026
@aditya-vithaldas
aditya-vithaldas marked this pull request as ready for review July 10, 2026 18:43
@aditya-vithaldas
aditya-vithaldas requested a review from a team as a code owner July 10, 2026 18:43

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7a3679672

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

color: stateById.get(key)?.color ?? labelById.get(key)?.color ?? undefined,
items: groupedIssues.groups.get(key) ?? [],
}));
return { columns, orphans: [] as IssueApiResponse[] };

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the no-state bucket for stale state IDs

When the project board is grouped by states, this new grouped branch bypasses the old state bucketing logic and always returns no orphans. buildGroupedIssues treats any non-empty issue.state_id as its own key even if that state no longer exists in states, so issues whose state was deleted now render under a raw state-id column instead of the board's No state bucket; that column also cannot be a valid drop target because resolveTargetStateId rejects keys not in stateById. Please keep the stale-state/no-state handling for the state-backed grouped board.

Useful? React with 👍 / 👎.

@martian56
martian56 merged commit 325ca8f into Devlaner:main Jul 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants