Conversation
added 7 commits
February 12, 2026 22:51
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
close : #176
🔍 구현한 내용
기기검색페이지, 노션 평가 기반으로 리펙토링 진행하였습니다.
기기 검색 페이지(DeviceSearchPage)의 코드 품질, 성능, 접근성을 개선하는 리팩토링 작업입니다.
UI 변경 없이 내부 로직만 개선했습니다.
주요 변경사항
중복된 useLayoutEffect 통합
isModalOpen 로직 명확화
useCallback으로 콜백 함수 최적화
ProductCard 리스트 렌더링 최적화
검색 Input에 aria-label 추가
필터 아이콘 버튼에 aria-label 추가
모달에 ESC 키로 닫기 및 ARIA 속성 추가
변경된 파일
src/hooks/useScrollState.ts
src/components/ProductCard/ProductCard.tsx
src/components/DeviceSearch/DeviceDetailModal.tsx
src/pages/devices/DeviceSearchPage.tsx
기대 효과
📸 스크린샷 or 실행 영상
📢 리뷰어에게