Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal secret handling policy #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SamPenrose
Copy link

Per Slack discussion, just to kick things off. Edit mercilessly.

@review-ninja
Copy link

ReviewNinja

@decause
Copy link
Member

decause commented Aug 17, 2016

👍 from @decause, perhaps a quick 👍 from @dxa4481 or other security folks?

@dxa4481
Copy link

dxa4481 commented Aug 17, 2016

Looks good to me, if the key/data is more sensitive then there are some best practices provided by OWASP we can follow:

https://www.owasp.org/index.php/Cryptographic_Storage_Cheat_Sheet#Rule_-_Ensure_that_any_secret_key_is_protected_from_unauthorized_access

jaypinho and others added 2 commits August 17, 2016 16:50
Just a couple small OCD changes. :)
Update CONTRIBUTING.md
@decause
Copy link
Member

decause commented Aug 22, 2016

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants