Don't require unnecessary OS permissions on MacOS #7028
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Makes it so that disabling screenshots doesn't trigger a permission request for screen recording on MacOS Monterey. This lets users who don't have access to changing permissions still use TestCafe when the permission is not necessary.
Approach
Changes the validateBrowsers method to not request extra permissions when screenshots are disabled on MacOS
References
Resolves #7019.
I'm sorry I couldn't update the tests but they don't seem to pass with or without my changes as noted in #7029. This also meant I couldn't really write test-cases.