-
Notifications
You must be signed in to change notification settings - Fork 3
๐ฅ๐ฅ๐ฅ์ฝ๋๋ฆฌ๋ทฐ๐ฅ๐ฅ๐ฅ #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: init
Are you sure you want to change the base?
Changes from 224 commits
17f8389
5920102
93509e6
23e139b
2325498
415bb2e
744fe14
047e7cd
eafdc75
111e836
adde1a7
666fffb
16d18fe
9966d23
62efdcf
f34d791
9a304bb
851fb0c
46462b7
69b21f1
e0347e2
e7c9270
c49dc38
9ec1f06
ac6d3b8
b1eba44
1063085
8d6d9c9
c81e804
2cb1303
3db8044
c1d3c95
e912364
cf47d9d
3311931
5382d94
717cbd2
34a6094
52e8704
fff796c
c7a4cf8
b99c235
a833151
8239b47
0961e32
09212e9
ae86df6
6fd9664
9422bbc
772d5c6
a72b990
acb1089
86fc1da
bb2a8f3
2561cda
7221107
3d1013b
2b7f820
c8e96b8
c231c3c
c403db1
c310b40
3ca565e
57407f9
80d9aea
02edc88
5873bff
399fd80
9d5bebf
7fbcaa1
93c2c0e
ba6e294
5f2cbe4
c803723
7c01557
e90d56f
5d1976c
25a2611
0b96eab
c94dac4
d573ea0
cf31b82
e7458d5
7a871ee
ba6088e
d13c57c
f49314e
eb4b0f4
5f39df4
93085a4
7ed1419
a402aae
0470343
6df8088
69857c1
1af210c
365792c
b62fd8b
cf79fe4
e2d8c96
3e588bf
f8a82e7
6a19be5
482b108
d339269
c2dd704
b0e7e9a
afc79f0
f760e3b
ee72a63
5f003eb
ce9418e
e466a92
18c2398
162037e
0a95ab0
1233b8d
1283b56
b3b3391
b49d71e
1d70177
92a7e61
a967cd3
4a3ad36
b825893
67f1cdc
c8f741a
93cc6d5
8f53be8
4faf295
9b1786d
c96cfe2
5bc1963
4972453
f8a2897
8ff71fb
5e9da2e
a8e41e7
95b00b2
fb61709
c6dacc8
73b2a2d
3d3beaa
c3c4962
322db0f
23f6226
c528017
00eadd6
6d3b503
b3573c6
30216d6
91cd19c
4a821e7
427e801
b7ed78a
b456fc4
500a8fa
d32f761
9f9b6bb
6a7778d
fdf8bb4
1d4a172
c3ef908
746876e
af7dd67
936aa32
fc27cc1
4cd5ae8
f0c53db
0a32654
a59f0bc
37b6db4
d6406aa
a4e8918
61e2a92
8035f25
7091f28
0a0676b
e7df8a5
0f4e7cc
021da4c
61627d2
eb99bf4
b0cc7a0
7a29509
563bcc4
bffb073
c50b2ec
20d421a
09c6ce9
beff87a
10f6519
54ae040
79cb2d4
55c7515
d76f3d2
4763914
fbb379f
1c22018
c86b274
7461088
774d284
55b4617
59c9cec
da63758
afc245a
5547e55
1e53463
fa6c657
d8dba97
c5859ef
d9d8431
86ae673
5fa15e8
2286806
c65846f
f41748d
749b456
2d69f2b
8d8b267
de9b1c3
1658c97
6c3ac1e
ec47d49
9fc37fe
d8928e0
a3b6939
d685e21
aac3c91
c9eda33
4615688
275c712
fb19359
fcde0d9
6da55bd
a322584
e2917be
9b3a789
16b8bf3
03b7e84
95e0c6f
17219f3
ddbc72b
a18c80a
3d28848
981d1ea
6c1d8b6
295d0cd
ab2b3b0
d3f63df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "projects": { | ||
| "default": "np-no-problem" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,11 @@ | ||
| # ๐ ํ ๋ฆฌํ์คํธ ์ ์ | ||
| ## ๐ ํ๋ฆฌํ์คํธ ๊ด๋ จ ์ฝ๋ฉํธ | ||
|
|
||
| <!-- ์ด์ ์ง์ธ๋ ์์ฑํด ์ฃผ์ธ์. --> | ||
| <!-- "sourcery:disable" --!> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question (documentation): Sourcery๋ฅผ ๋นํ์ฑํํ๋ ๋ชฉ์ ์ ๋ช ํํ ํด์ฃผ์ธ์ ์ฌ๊ธฐ์ Sourcery๋ฅผ ๋นํ์ฑํํ๋ ์ด์ ๋ฅผ ์ค๋ช ํด ์ฃผ์ค ์ ์๋์? ๋ค๋ฅธ ๊ธฐ์ฌ์๋ค์๊ฒ ์ ์ฉํ ์ ๋ณด์ผ ์ ์์ต๋๋ค. Original comment in Englishquestion (documentation): Clarify the purpose of disabling Sourcery Could you explain why Sourcery is being disabled here? This might be useful information for other contributors. |
||
| <!-- closes #issue-number --> | ||
| <!-- ์ด์ ์ฌ๋ฌ ๊ฐ ์ผ ๊ฒฝ์ฐ, closes #1, closes #2 --> | ||
| <!-- https://docs.github.com/ko/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue --> | ||
|
|
||
| ## ๐ ์์ ๋ด์ฉ | ||
|
|
||
| ์์ ํ ๋ด์ฉ์ด๋ ์ถ๊ฐํ ๊ธฐ๋ฅ์ ๋ํด ์์ธํ ์ค๋ช ํด ์ฃผ์ธ์. | ||
|
|
||
| ## ๐ง ๋ณ๊ฒฝ ์ฌํญ | ||
|
|
||
| - [ ] ๐ README.md | ||
| - [ ] ๐ฆ package.json | ||
| - [ ] ๐ฅ ํ์ผ ์ญ์ | ||
| - [ ] ๐งน ๊ทธ ์ธ ex) .gitignore ๋ฑ | ||
|
|
||
| ์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ์ ์์ฝํด ์ฃผ์ธ์. | ||
| <br/> | ||
|
|
||
| ## ๐ธ ์คํฌ๋ฆฐ์ท (์ ํ ์ฌํญ) | ||
|
|
||
| ์์ ๋ ํ๋ฉด ๋๋ ๊ธฐ๋ฅ์ ์์ฐํ ์ ์๋ ์คํฌ๋ฆฐ์ท์ ์ฒจ๋ถํด ์ฃผ์ธ์. | ||
|
|
||
| ## ๐ ๊ธฐํ | ||
|
|
||
| ์ถ๊ฐ์ ์ผ๋ก ์ ๋ฌํ๊ณ ์ถ์ ๋ด์ฉ์ด๋ ํน๋ณํ ์๊ตฌ ์ฌํญ์ด ์์ผ๋ฉด ์์ฑํด ์ฃผ์ธ์. | ||
| <!-- ์์ ๋ ํ๋ฉด ๋๋ ๊ธฐ๋ฅ์ ์์ฐํ ์ ์๋ ์คํฌ๋ฆฐ์ท์ ์ฒจ๋ถํด ์ฃผ์ธ์.--!> | ||
| <br/> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Firebase Hosting by Click | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| deploy: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Setup node.js 20.x | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 20 | ||
| cache: 'npm' | ||
| - name: Install | ||
| run: npm ci | ||
| - name: Build | ||
| env: | ||
| VITE_FIREBASE_API_KEY: ${{ secrets.VITE_FIREBASE_API_KEY }} | ||
| VITE_FIREBASE_AUTH_DOMAIN: ${{ secrets.VITE_FIREBASE_AUTH_DOMAIN }} | ||
| VITE_FIREBASE_PROJECT_ID: ${{ secrets.VITE_FIREBASE_PROJECT_ID }} | ||
| VITE_FIREBASE_STORAGE_BUCKET: ${{ secrets.VITE_FIREBASE_STORAGE_BUCKET }} | ||
| VITE_FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.VITE_FIREBASE_MESSAGING_SENDER_ID }} | ||
| VITE_FIREBASE_APP_ID: ${{ secrets.VITE_FIREBASE_APP_ID }} | ||
| VITE_FIREBASE_MEASUREMENT_ID: ${{ secrets.VITE_FIREBASE_MEASUREMENT_ID }} | ||
| VITE_FIREBASE_REALTIME_DB: ${{ secrets.VITE_FIREBASE_REALTIME_DB }} | ||
| VITE_YOUTUBE_API_KEY: ${{ secrets.VITE_YOUTUBE_API_KEY }} | ||
|
|
||
| run: npm run build | ||
| - uses: FirebaseExtended/action-hosting-deploy@v0 | ||
| with: | ||
| firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}' | ||
| projectId: np-no-problem | ||
| channelId: live |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: PR Auto Hosting | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
|
|
||
| jobs: | ||
| deploy: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Setup node.js 20.x | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 20 | ||
| cache: 'npm' | ||
| - name: Install | ||
| run: npm ci | ||
| - name: Build | ||
| env: | ||
| VITE_FIREBASE_API_KEY: ${{ secrets.VITE_FIREBASE_API_KEY }} | ||
| VITE_FIREBASE_AUTH_DOMAIN: ${{ secrets.VITE_FIREBASE_AUTH_DOMAIN }} | ||
| VITE_FIREBASE_PROJECT_ID: ${{ secrets.VITE_FIREBASE_PROJECT_ID }} | ||
| VITE_FIREBASE_STORAGE_BUCKET: ${{ secrets.VITE_FIREBASE_STORAGE_BUCKET }} | ||
| VITE_FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.VITE_FIREBASE_MESSAGING_SENDER_ID }} | ||
| VITE_FIREBASE_APP_ID: ${{ secrets.VITE_FIREBASE_APP_ID }} | ||
| VITE_FIREBASE_MEASUREMENT_ID: ${{ secrets.VITE_FIREBASE_MEASUREMENT_ID }} | ||
| VITE_FIREBASE_REALTIME_DB: ${{ secrets.VITE_FIREBASE_REALTIME_DB }} | ||
| VITE_YOUTUBE_API_KEY: ${{ secrets.VITE_YOUTUBE_API_KEY }} | ||
| run: npm run build | ||
| - uses: FirebaseExtended/action-hosting-deploy@v0 | ||
| with: | ||
| firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}' | ||
| projectId: np-no-problem | ||
| channelId: live |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "autoAdd": false, | ||
| "emojiFormat": "emoji", | ||
| "scopePrompt": false, | ||
| "messagePrompt": false, | ||
| "capitalizeTitle": false, | ||
| "gitmojisUrl": "https://gist.githubusercontent.com/seoyoonyi/8d8db43873ad4908a0fdb9c4f18737c4/raw/28cb248201e0001a035014c14a25f8d1636dee91/gitmoji.json" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| npx lint-staged | ||
| npx lint-staged |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,3 @@ | ||
| # React + TypeScript + Vite | ||
| # NP - No Problem | ||
|
|
||
| This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules. | ||
|
|
||
| Currently, two official plugins are available: | ||
|
|
||
| - [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/README.md) uses [Babel](https://babeljs.io/) for Fast Refresh | ||
| - [@vitejs/plugin-react-swc](https://github.com/vitejs/vite-plugin-react-swc) uses [SWC](https://swc.rs/) for Fast Refresh | ||
|
|
||
| ## Expanding the ESLint configuration | ||
|
|
||
| If you are developing a production application, we recommend updating the configuration to enable type aware lint rules: | ||
|
|
||
| - Configure the top-level `parserOptions` property like this: | ||
|
|
||
| ```js | ||
| export default { | ||
| // other rules... | ||
| parserOptions: { | ||
| ecmaVersion: 'latest', | ||
| sourceType: 'module', | ||
| project: ['./tsconfig.json', './tsconfig.node.json', './tsconfig.app.json'], | ||
| tsconfigRootDir: __dirname, | ||
| }, | ||
| } | ||
| ``` | ||
|
|
||
| - Replace `plugin:@typescript-eslint/recommended` to `plugin:@typescript-eslint/recommended-type-checked` or `plugin:@typescript-eslint/strict-type-checked` | ||
| - Optionally add `plugin:@typescript-eslint/stylistic-type-checked` | ||
| - Install [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) and add `plugin:react/recommended` & `plugin:react/jsx-runtime` to the `extends` list | ||
| # My Idoru | ||
|
Comment on lines
+1
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (documentation): README ๋ด์ฉ์ ํ์ฅํ๋ ๊ฒ์ ๊ณ ๋ คํด๋ณด์ธ์ ์๋ก์ด README๋ ๋งค์ฐ ๊ฐ๋จํฉ๋๋ค. ํ๋ก์ ํธ, ๋ชฉ์ , ์ฌ์ฉ ๋ฐฉ๋ฒ์ ๋ํ ๋ ๋ง์ ์ ๋ณด๋ฅผ ์ถ๊ฐํ๋ ๊ฒ์ ๊ณ ๋ คํด๋ณด์ธ์. Original comment in Englishsuggestion (documentation): Consider expanding the README content The new README is very brief. Consider adding more information about the project, its purpose, and how to use it. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "rules": { | ||
| ".read": true, | ||
| ".write": true | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "hosting": { | ||
| "public": "dist", | ||
| "ignore": ["firebase.json", "**/.*", "**/node_modules/**"], | ||
| "rewrites": [ | ||
| { | ||
| "source": "**", | ||
| "destination": "/index.html" | ||
| } | ||
| ] | ||
| }, | ||
| "database": { | ||
| "rules": "database.rules.json" | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (documentation): ํ๊ตญ์ด ํ ์คํธ์ ์คํ๋ฅผ ์์ ํ์ธ์
'ํ๋ฆฌํ์คํธ'์ ๊ณต๋ฐฑ์ด ์์ด์ผ ํฉ๋๋ค. ์ฌ๋ฐ๋ฅธ ํํ๋ 'ํ ๋ฆฌํ์คํธ'์ ๋๋ค.
Original comment in English
nitpick (documentation): Correct typo in Korean text
There should be a space in 'ํ๋ฆฌํ์คํธ'. The correct form is 'ํ ๋ฆฌํ์คํธ'.