test(security): add meter notes SQL injection regression coverage (#671) - #722
Open
nupedev wants to merge 1 commit into
Open
test(security): add meter notes SQL injection regression coverage (#671)#722nupedev wants to merge 1 commit into
nupedev wants to merge 1 commit into
Conversation
|
@nupedev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #671
Audits the meter-notes SQLite access layer and adds a regression test for SQL-like meter identifiers.
Changes
The current
meterNotes.tsimplementation uses prepared statements and bound parameters for note insertion, latest-note queries, paginated queries, counts, and deletion. This branch preserves that safe implementation and adds explicit security coverage so a quoted identifier such asmeter-1' OR 1=1 --is treated as data rather than executable SQL. The regression checks both latest and paginated note reads across separate meter IDs.Verification
tests/meters-note.test.ts— 6 passed.git diff --check— passed.No interpolated
meter_idSQL was found in the audited meter-notes operations. This PR intentionally avoids duplicating an already-present parameterization fix and instead prevents regression in the current codebase.