Skip to content

test(daemon-app): wait for the stable terminal state, not the draining window #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeusData merged 1 commit into from
Jul 27, 2026
+12 −24
Merged

test(daemon-app): wait for the stable terminal state, not the draining window #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 12 additions & 24 deletions tests/test_daemon_application.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,23 +1462,6 @@ static bool app_wait_for_active_jobs(cbm_daemon_application_t *application, size
return false;
}

static bool app_wait_for_terminal_job_with_subscribers(cbm_daemon_application_t *application,
const char *project,
size_t minimum_subscribers) {
uint64_t deadline = cbm_now_ms() + APP_TEST_TIMEOUT_MS;
while (cbm_now_ms() < deadline) {
if (cbm_daemon_application_active_jobs(application) == 0 &&
cbm_daemon_application_job_subscribers(application, project) >= minimum_subscribers) {
return true;
}
/* Yield like every sibling wait helper: a sleepless spin pins a core
* and can starve the daemon threads it polls on scarce-CPU runners
* (windows-11-arm release leg, run 30305464193). */
cbm_usleep(1000);
}
return false;
}

typedef struct {
cbm_daemon_application_t *application;
const char *project;
Expand Down Expand Up @@ -2646,16 +2629,21 @@ TEST(daemon_application_fresh_request_does_not_reuse_terminal_subscribed_job) {
bool first_worker_ready_to_publish =
all_subscribed && app_wait_for_atomic_int(&fake.destroys, 1);
atomic_store(&fake.release_destroy, true);
bool terminal_with_prior_subscribers =
first_worker_ready_to_publish &&
app_wait_for_terminal_job_with_subscribers(application, project, PRIOR_SUBSCRIBERS / 2U);
/* Wait only for the stable end-state. Publish flips terminal and lets the
* blocked prior requests drain in the same breath, so "terminal AND still
* subscribed" is a transient window no poll cadence can pin (release runs
* 30305464193 and 30309182389 missed it from both directions). The
* production guard ignores subscriber counts — find_active_job skips any
* terminal job — and the stale/fresh assertions below catch a reuse in
* every interleaving. */
bool job_terminal = first_worker_ready_to_publish && app_wait_for_active_jobs(application, 0);

uint8_t *fresh = NULL;
uint32_t fresh_length = 0;
cbm_daemon_runtime_application_status_t fresh_status =
terminal_with_prior_subscribers ? app_test_request(&callbacks, sessions[PRIOR_SUBSCRIBERS],
tool, tool_length, &fresh, &fresh_length)
: CBM_DAEMON_RUNTIME_APPLICATION_REJECTED;
job_terminal ? app_test_request(&callbacks, sessions[PRIOR_SUBSCRIBERS], tool, tool_length,
&fresh, &fresh_length)
: CBM_DAEMON_RUNTIME_APPLICATION_REJECTED;
for (size_t i = 0; i < PRIOR_SUBSCRIBERS; i++) {
if (started[i]) {
(void)cbm_thread_join(&threads[i]);
Expand All @@ -2672,7 +2660,7 @@ TEST(daemon_application_fresh_request_does_not_reuse_terminal_subscribed_job) {
ASSERT_TRUE(setup);
ASSERT_TRUE(all_subscribed);
ASSERT_TRUE(first_worker_ready_to_publish);
ASSERT_TRUE(terminal_with_prior_subscribers);
ASSERT_TRUE(job_terminal);
ASSERT_EQ(fresh_status, CBM_DAEMON_RUNTIME_APPLICATION_OK);
ASSERT_EQ(atomic_load(&fake.starts), 2);
ASSERT_EQ(atomic_load(&fake.destroys), 2);
Expand Down
Loading