ci,test: keep a spaced SANITIZE value one make argument end to end - #1223
Merged
Conversation
The windows-11-arm leg's first execution (broad matrix, release dry
run) died before any test ran: the trap-UBSan SANITIZE value passed
unquoted through the workflow ternary, so -fsanitize-trap=undefined
arrived as its own word and make consumed the leading -f as its
makefile flag ('No rule to make target sanitize-trap=undefined').
- The workflow quotes the ternary value so test.sh receives one
argument.
- test.sh forwards make arguments through an ARRAY instead of a
re-split string, so a VAR=VAL whose value contains spaces survives
every boundary (empty-array expansion kept bash-3.2-safe for the
macOS runners under set -u).
Verified: argument-parse proof (argc=1 with the four-flag value) and a
full macOS suite run through the changed plumbing, 6776 passed,
0 failed — identical totals.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-11-arm leg's first execution (broad matrix, release dry run) died before any test ran: the trap-UBSan
SANITIZEvalue passed unquoted through the workflow ternary, so-fsanitize-trap=undefinedarrived as its own word and make consumed the leading-fas its makefile flag.test.shreceives one argument.test.shforwards make arguments through an array instead of a re-split string, so aVAR=VALwhose value contains spaces survives every boundary (empty-array expansion kept bash-3.2-safe for the macOS runners underset -u).Verified: argument-parse proof (argc=1 with the four-flag value) and a full macOS suite run through the changed plumbing — 6776 passed, 0 failed, identical totals. The windows-11-arm leg itself is broad-matrix-only; the follow-up release dry run after this merges is its validation.