Skip to content

Fix C++26 clang compilation #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix C++26 clang compilation #709

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eeed7a
Rename 'module' struct to 'module_t'
Lgt2x May 21, 2025
a5a34d5
Fix array pointer comparison error, add comment
Lgt2x May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Descent3/robotfire.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ void WBSetupFireAnim(object *obj, otype_wb_info *static_wb, int wb_index) {

p_dwb->wb_anim_mask = p_dwb->cur_firing_mask;

if (static_wb->anim_start_frame != static_wb->anim_end_frame) {
// LGT: Awkward array comparison by pointer, needs investivation to understand the actual intent
if (+static_wb->anim_start_frame != static_wb->anim_end_frame) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because both LHS and RHS are arrays in their own right, the comparison always evaluates to true and should be deleted altogether.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right this test is bogus, I kept it alive to highlight a potential bug that needs to be looked into.

p_dwb->flags |= DWBF_ANIMATING;
p_dwb->wb_anim_frame = static_wb->anim_start_frame[p_dwb->cur_firing_mask];
}
Expand Down
Loading