Skip to content

Conversation

@tophyr
Copy link
Contributor

@tophyr tophyr commented Jun 28, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Replace renderer/ with the Piccu engine.

Related Issues

Likely massively conflicts with @Lgt2x's #457

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

@Lgt2x
Copy link
Member

Lgt2x commented Jun 28, 2024

No way we integrate that in one go. Need to go step by step, understanding changes and their implication. Piccu and this project have massively different goals and standards, if we want to merge we need to go slowly and wisely

@Lgt2x Lgt2x marked this pull request as draft June 28, 2024 22:18
@tophyr
Copy link
Contributor Author

tophyr commented Jun 28, 2024

Yeah, I agree. This is mostly a POC. The overall goal, for this project, I think should just be "modernize the renderer" so that it uses GL3+, VBOs, and shaders. Piccu is one way to accomplish that, but certainly not the only one. This commit stack so far isn't even tested at runtime, I just literally got it to build on my macbook and put it up. Digging in to grok the old renderer, piccu renderer, and the differences, will take a chonkin bit more time.

@tophyr
Copy link
Contributor Author

tophyr commented Jun 28, 2024

weird that none of these build failures occur locally for me. hm

@Lgt2x
Copy link
Member

Lgt2x commented Jul 7, 2024

Let's close this one and cherry-pick rendering improvements one by one from Piccu. We can keep this work as a reference

@Lgt2x Lgt2x closed this Jul 7, 2024
@tophyr tophyr deleted the merge-piccu-renderer branch July 27, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants