Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1038 clear country #1052

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

1038 clear country #1052

wants to merge 16 commits into from

Conversation

qchiujunhao
Copy link
Collaborator

Acceptance Criteria

  • Clearing country also clears any selected location within the country

Test Cases

  • Clear country with location within country selected
  • Clear country with no location within country selected
  • Clear country and select a new country, verify new value saved
  • Clear country/location and select a new country/location, verify new values saved

@qchiujunhao qchiujunhao self-assigned this Oct 9, 2023
@qchiujunhao qchiujunhao linked an issue Oct 9, 2023 that may be closed by this pull request
Create Group: if a country is selected (even accidentally) there does not appear to be a way to clear it, only a location inside a country can be cleared #1038
Open
@qchiujunhao
Copy link
Collaborator Author

image
Please see the above screen shot for reviewing the change. I added a button clear selected country. Need @hyihua help test the test cases with location selected. Not sure why the location selector did not appear in my local testing website.

@hyihua
Copy link
Collaborator

hyihua commented Nov 6, 2023 •
edited
Loading

I tried to help but the location selector didn't show on my end either. And I also tried to switch to other branches and no location selector either. @qchiujunhao

image

@qchiujunhao qchiujunhao marked this pull request as ready for review November 6, 2023 03:33
@qchiujunhao qchiujunhao marked this pull request as draft November 7, 2023 03:49
@qchiujunhao qchiujunhao removed the request for review from marlonkeating November 7, 2023 03:49
@qchiujunhao
Copy link
Collaborator Author

looks like the change works. but couldn't test with test case "Clear country with location within country selected" because of issue #1077

@qchiujunhao
Copy link
Collaborator Author

@marlonkeating Due to issue #1077 , not able to test this change locally. Can we test this PR using heroku?

@qchiujunhao qchiujunhao added javascript Pull requests that update Javascript code Front End Primarily front-end (react/javascript) labels Dec 15, 2023
@qchiujunhao qchiujunhao marked this pull request as ready for review December 15, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlonkeating marlonkeating Awaiting requested review from marlonkeating

At least 1 approving review is required to merge this pull request.

Assignees

@qchiujunhao qchiujunhao

Labels
Front End Primarily front-end (react/javascript) javascript Pull requests that update Javascript code ready for review
Projects
None yet
Milestone
No milestone
2 participants
@qchiujunhao @hyihua