Add rpc load blance call helper #2876
Open
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g1nt0ki
reviewed
Apr 13, 2025
helpers/rpc.ts
Outdated
| const GlobalEndpointsCooldown: { [key: string]: number } = {} | ||
|
|
||
| async function sleep(time: number) { | ||
| return new Promise((resolve) => setTimeout(resolve, time)) |
There was a problem hiding this comment.
setTimeout uses millisecond format iirc, so need to either *1000 here or send in ms in calls
g1nt0ki
requested changes
Apr 13, 2025
helpers/rpc.ts
Outdated
|
|
||
| // anyway, sleep one second | ||
| await sleep(1) | ||
| } while(true) |
There was a problem hiding this comment.
hmm, I dont like the idea of infinitely looping till something works, sometimes the request is bad
helpers/rpc.ts
Outdated
|
|
||
| if (httpResponse.status === 200) { | ||
| return httpResponse.data | ||
| } else if (httpResponse.status >= 400 && httpResponse.status < 500) { |
There was a problem hiding this comment.
again, what if the request is bad, like we are requesting for token details of non existent token? we are punishing the endpoint for a bad request. maybe instead of immediately cooling down a endpoint, we see if some other endpoint gives 200 result and then add cooldown to bad endpoint based on their response/error code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper function help to balance and cache rpc calls