Skip to content

Conversation

@treeoflife2
Copy link
Member

No description provided.

@treeoflife2 treeoflife2 marked this pull request as draft November 6, 2025 13:57
@treeoflife2
Copy link
Member Author

 PASS  api-tests/src/tvl/protocols.test.ts (7.287 s)
  TVL API - Protocols
    GET /protocols                                                                                               
      √ should return list of all protocols (6 ms)                                                               
      √ should return protocols with required fields (2757 ms)                                                   
      √ should return protocols with valid data types (8 ms)                                                     
      √ should return protocols with valid TVL values (2814 ms)                                                  
      √ should return protocols with valid chain TVLs structure (69 ms)                                          
      √ should handle protocols with borrowed amounts (25 ms)                                                    
      √ should return protocols ordered by TVL descending (11 ms)                                                
      √ should have consistent data structure (15 ms)                                                            
      √ should return protocols with categories (4 ms)                                                           
      √ should return protocols with valid percentage changes (9 ms)                                             
      √ should handle protocols with parent protocol slug (6 ms)                                                 
      √ should validate complete protocol structure (2 ms)                                                       
                                                                                                                 
Test Suites: 1 passed, 1 total                                                                                   
Tests:       12 passed, 12 total                                                                                 
Snapshots:   0 total
Time:        7.578 s, estimated 10 s
Ran all test suites matching /api-tests/i.

@treeoflife2 treeoflife2 requested a review from g1nt0ki November 6, 2025 13:57
Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing pnpm lock file update?

maxWorkers: 1,
ci: false,
cacheDirectory: '/tmp/jest-cache',
testEnvironment: "node",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, unsure if this will break current github action flow that has a dependency on test passing before deploying to aws

1. **Cache responses** - Use `beforeAll` to fetch once
2. **Group by purpose** - Basic → Data → Metadata → Edge Cases
3. **Test samples** - Don't iterate all items (use `.slice(0, 10)`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I would do here is, take the top 10 (usually most valuable protocols) & and a random 10, maybe add a helper for this?

outputName: 'junit.xml',
}]
],
coverageDirectory: './coverage',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can skip the coverage as these are not unit tests but e2e?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if there is a config to disable it in the config

"test:api:coverage": "jest --testPathPattern=api-tests --maxWorkers=1 --coverage",
"test:api": "cd api-tests && jest",
"test:api:watch": "cd api-tests && jest --watch",
"test:api:coverage": "cd api-tests && jest --coverage",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove coverage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

g1nt0ki and others added 18 commits November 7, 2025 17:06
* number

* check decimals before transform

* avnu address padding
* token mappings

* makina name
…nd combine dipcoin spot and dipcoin perps into one dipcoin group. (DefiLlama#10931)

* Add DipCoin Perp TVL Adapter for SUI

* add tvl、volume、fee three meters for dipcoin spot and dipcoin perps. and combine dipcoin spot and dipcoin perps into one dipcoin group.

* add tvl、volume、fee three meters for dipcoin spot and dipcoin perps. and combine dipcoin spot and dipcoin perps into one dipcoin group.

* add tvl、volume、fee three meters for dipcoin spot and dipcoin perps. and combine dipcoin spot and dipcoin perps into one dipcoin group.

---------

Co-authored-by: alan <[email protected]>
@treeoflife2 treeoflife2 marked this pull request as ready for review November 13, 2025 18:01
@treeoflife2
Copy link
Member Author

Writing JSON test report to ./test-results/junit.json
Seed: 1888326014
Test Suites: 15 passed, 15 total
Tests: 203 passed, 203 total
Snapshots: 0 total
Time: 56.782 s
Ran all test suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.