Coins Api #187
Merged
Coins Api #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g1nt0ki
reviewed
Oct 20, 2025
g1nt0ki
reviewed
Oct 20, 2025
g1nt0ki
reviewed
Oct 20, 2025
| return bodies; | ||
| } | ||
|
|
||
| function sleep(ms: number) { |
There was a problem hiding this comment.
this we already have defined sleep somewhere else?
There was a problem hiding this comment.
I cant find a timeout/sleep anywhere else in the codebase
There was a problem hiding this comment.
so, there was sleep already here
g1nt0ki
requested changes
Oct 20, 2025
g1nt0ki
reviewed
Oct 23, 2025
| }; | ||
|
|
||
| const coinsApiKey = getEnvValue("COINS_API_KEY") | ||
| const bodySize = 2; // 100; |
There was a problem hiding this comment.
this was test code should have reverted back to 100
g1nt0ki
reviewed
Oct 23, 2025
| return res; | ||
| } catch { | ||
| await sleep(5_000 + 10_000 * Math.random()); | ||
| restCallWrapper(request, retries--, name); |
There was a problem hiding this comment.
missing await, and why both recursive call and a while loop, should have been one or the other
g1nt0ki
reviewed
Oct 23, 2025
| readKeys = readKeys.filter((PK: string) => { | ||
| if (timestamp !== "now") return true; | ||
| if (priceCache[PK]) { | ||
| aggregatedRes[PK] = { ...priceCache[PK], PK }; |
There was a problem hiding this comment.
you read from the cache, but there is no code that sets to the cache
g1nt0ki
reviewed
Oct 23, 2025
|
|
||
| const bodies = getBodies(readKeys, timestamp); | ||
| const tokenData: CoinsApiData[][] = []; | ||
| await runInPromisePool({ |
There was a problem hiding this comment.
lot of code duplication between /prices and /mcaps call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.