Fix Solana address detection - #49
Open
vermi321 wants to merge 1 commit into
Open
Conversation
vermi321
commented
Nov 24, 2024
| const solanaAddressRegex = /([1-9A-HJ-NP-Za-km-z]{39,44})/g; | ||
| const res = tweetText.match(solanaAddressRegex); | ||
| if (!res) return false; | ||
| return res.some((str) => regexUpper.test(str) && regexLower.test(str) && regexNumber.test(str)); |
Author
There was a problem hiding this comment.
Filtering out address without characters in any of these 3 categories isn't right, because it would result in false negatives - it is possible to have Solana address without numbers or lower/upper cased letter.
Member
|
I think we stopped do this check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment the TS build doesn't pass.
The reason for that is the
checkForSolAddressfunction returns boolean while in the code it is expected to returnstring[] | null. Also the extra check in thecheckForSolAddressfor A-Z, a-z and 0-9 matches don't do anything extra which isn't already covered by the Solana address regex a few lines above, which makes it simply overcomplicated and it can be inlined just like EVM address matcher.