-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix: tvl and staking #17173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tvl and staking #17173
Conversation
|
The adapter at projects/obyte-city exports TVL: |
|
The adapter at projects/obyte-city exports TVL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the incorrect assignment of TVL and staking metrics for the Obyte City adapter. Previously, the staking function was calculating total TVL (all assets), while the TVL was empty. The fix correctly separates these concerns: TVL now tracks GBYTE locked in the platform, while staking tracks deposited CITY tokens.
Key changes:
- Simplified
totalTvl()to calculate only GBYTE balances instead of all assets - Added new
totalStaking()function to track deposited CITY token supply - Corrected module exports to properly assign
tvlandstakingfunctions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The adapter at projects/obyte-city exports TVL: |
|
Where on the app UI can users deposit GBYTE tokens? |
It was possible during the initial sale: https://city.obyte.org/faq#what-is-the-initial-sale-period |
|
Can users withdraw their GBYTE deposits? If not, it cant be counted as TVL |
fixed |
|
The adapter at projects/obyte-city exports TVL: |
Hi, here are the fixes for the PR: #17119
The TVL was originally TVL and backed by GBYTE — I’ve reverted it and added the correct staking display.