-
Notifications
You must be signed in to change notification settings - Fork 23
Normalize project name by replacing underscore with dash #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
lionello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was expecting something generic, but this is GCP specific
src/pkg/cli/client/byoc/gcp/byoc.go
Outdated
| } | ||
|
|
||
| func (b *ByocGcp) getLogStream(ctx context.Context, gcpLogsClient GcpLogsClient, req *defangv1.TailRequest) (client.ServerStream[defangv1.TailResponse], error) { | ||
| fmt.Printf("Getting logs for project %s ===========\n", req.Project) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be removed
The GCP specific parts are actually not related to the normalization, more of supporting it. The main changes are in the compose folder, which changes/normalizes the project name before sending it to deploy/tail/subscribe, which are provider agnostic. |
Description
To allow handling of project names with underscore in it in GCP provider
Linked Issues
Fixes https://github.com/DefangLabs/defang-mvp/issues/2533
Checklist