feat: allow domain name as endpoint address #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-chmielewski
force-pushed
the
213-gateway-by-domain
branch
2 times, most recently
from
cc69417 to
6c02f30
Compare
j-chmielewski
force-pushed
the
213-gateway-by-domain
branch
from
6c02f30 to
b6f2dbc
Compare
j-chmielewski
force-pushed
the
213-gateway-by-domain
branch
from
f874dfc to
fbfee2b
Compare
moubctez
reviewed
Apr 23, 2024
src/host.rs
Outdated
| @@ -53,6 +53,15 @@ impl Peer { | |||
| self.allowed_ips = allowed_ips; | |||
| } | |||
|
|
|||
| /// Resolves endpoint address to SocketAddr and sets the field | |||
There was a problem hiding this comment.
Suggested change
| /// Resolves endpoint address to SocketAddr and sets the field | |
| /// Resolves endpoint address to [SocketAddr] and sets the field. |
Chyba tak 😉
moubctez
reviewed
Apr 23, 2024
src/utils.rs
Outdated
| @@ -340,3 +344,12 @@ pub(crate) fn clean_fwmark_rules(fwmark: u32) -> Result<(), WireguardInterfaceEr | |||
| netlink::delete_main_table_rule(IpVersion::IPv6, 0)?; | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Resolves domain name to SocketAddr | |||
There was a problem hiding this comment.
Suggested change
| /// Resolves domain name to SocketAddr | |
| /// Resolves domain name to [SocketAddr]. |
moubctez
reviewed
Apr 23, 2024
src/host.rs
Outdated
| @@ -53,6 +53,15 @@ impl Peer { | |||
| self.allowed_ips = allowed_ips; | |||
| } | |||
|
|
|||
| /// Resolves endpoint address to SocketAddr and sets the field | |||
| pub fn set_endpoint(&mut self, endpoint: &str) -> Result<(), WireguardInterfaceError> { | |||
| self.endpoint = match endpoint.parse() { | |||
There was a problem hiding this comment.
Suggested change
| self.endpoint = match endpoint.parse() { | |
| self.endpoint = Some(resolve(endpoint)?); |
.to_socket_addr() i tak najpierw próbuje zrobić .parse(), więc nie potrzeba dublować
https://doc.rust-lang.org/src/std/net/socket_addr.rs.html#282-289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.