Skip to content

Conversation

@ElectronicsArchiver
Copy link
Contributor

@ElectronicsArchiver ElectronicsArchiver commented Jul 17, 2022



This is currently only a draft PR as I'd like you to review #5 first.



Badge Changes

  • General code refactoring

  • Fixed flying unit crash

  • Fixed various logic, .. bugs





@Def-Try
Copy link
Owner

Def-Try commented Jul 18, 2022

so good. thanks

@ElectronicsArchiver
Copy link
Contributor Author

@Def-Try In your original version did everything work or what was your exact progress / goal?

@Def-Try
Copy link
Owner

Def-Try commented Jul 20, 2022

Everything did work

@ElectronicsArchiver
Copy link
Contributor Author

Right, well then I'll have to do some debugging~

@ElectronicsArchiver
Copy link
Contributor Author

Not everything works yet~

@Def-Try
Copy link
Owner

Def-Try commented Jul 21, 2022

PR still in progress? Just saw you comment on readme formatting. Btw, Would you like me to add you as a collaborator? You've done a lot more than TheEE.

@ElectronicsArchiver
Copy link
Contributor Author

as a collaborator

Add me where to what exactly?

@Def-Try
Copy link
Owner

Def-Try commented Jul 21, 2022

To parkour mod repository

@ElectronicsArchiver
Copy link
Contributor Author

To parkour mod repository

Yeah, but in what way, I didn't see a Credits.md file etc.

And if you mean the contributors sections,
there people are automatically added.

@ElectronicsArchiver
Copy link
Contributor Author

Btw, do you know if there is a way to scroll up in the console? (Alpha Version)

@Def-Try
Copy link
Owner

Def-Try commented Jul 21, 2022

Oh. Didnt know.
To scroll in console you can use PgUp or PgDn I think.

@ElectronicsArchiver
Copy link
Contributor Author

Oh. Didnt know. To scroll in console you can use PgUp or PgDn I think.

Mhm, weird, doesn't work for me..

@Def-Try
Copy link
Owner

Def-Try commented Jul 21, 2022

Then I think it's impossible.

@ElectronicsArchiver
Copy link
Contributor Author

Hope it will be fixed soon, that's such a vital thing to be able to do..

@ElectronicsArchiver
Copy link
Contributor Author

@Def-Try I compared to the original and I think it's relatively the same now, could you check~

@ElectronicsArchiver
Copy link
Contributor Author

Btw, do you have a test level / world ?
If so, you might wanna add it to the mod~

@Def-Try
Copy link
Owner

Def-Try commented Jul 21, 2022

Hold - broken, while enabled using stamina to float, does not depend on the walls
Gravity pads, antigravity field, funnel and stick gel - broken, while trying to interact nothing happens
Other mechanics are working.

@ElectronicsArchiver
Copy link
Contributor Author

So do you have a test map?

@Def-Try
Copy link
Owner

Def-Try commented Jul 21, 2022

I do not

@ElectronicsArchiver
Copy link
Contributor Author

Debugging ES5 / Rhino code sure isn't fun~

How is there not an up-to-date java implementation of ecmascript??
I wish it were Deno..

@ElectronicsArchiver
Copy link
Contributor Author

@Def-Try I commited the next refactoring step with the problem I can't seem to get fixed, maybe you know how to..

Basically since it's awful ES5 codes and I wanted to isolate your code as much as possible, like you would do with ES6, I wrapped them in 'module' syntax where needed.

However, for some reason (as can be seen in the console) the interface global instance is just an empty object.

@Def-Try
Copy link
Owner

Def-Try commented Aug 15, 2022

Any updates on problem? I dunno what to do with this, maybe copy interface code to ui module?

@ElectronicsArchiver
Copy link
Contributor Author

It seems the global object isn't readable.
I will try some stuff I guess~

@ElectronicsArchiver
Copy link
Contributor Author

Btw, how was the jumping supposed to work since the spacebar is also the pause button?

@Def-Try
Copy link
Owner

Def-Try commented Aug 17, 2022

mod was actually started on server as simple js script, so we didnt have pause problem. Anyways, player can just host server and pause will can not be enabled

@ElectronicsArchiver
Copy link
Contributor Author

That should probably be mentioned somewhere..

@Def-Try
Copy link
Owner

Def-Try commented Aug 17, 2022

yes..

@ElectronicsArchiver
Copy link
Contributor Author

So it is a server-only mod?

For some reason the ClientLoadEvent isn't triggered..

@Def-Try
Copy link
Owner

Def-Try commented Aug 17, 2022

it started as server-only mod, but now it's not server only

@ElectronicsArchiver
Copy link
Contributor Author

So it would be appropriate to split up the code into server-side / client-side..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants