-
Notifications
You must be signed in to change notification settings - Fork 1
Code Refactoring #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Code Refactoring #6
Conversation
|
so good. thanks |
|
@Def-Try In your original version did everything work or what was your exact progress / goal? |
|
Everything did work |
|
Right, well then I'll have to do some debugging~ |
|
Not everything works yet~ |
|
PR still in progress? Just saw you comment on readme formatting. Btw, Would you like me to add you as a collaborator? You've done a lot more than TheEE. |
Add me where to what exactly? |
|
To parkour mod repository |
Yeah, but in what way, I didn't see a Credits.md file etc. And if you mean the contributors sections, |
|
Btw, do you know if there is a way to scroll up in the console? (Alpha Version) |
|
Oh. Didnt know. |
Mhm, weird, doesn't work for me.. |
|
Then I think it's impossible. |
|
Hope it will be fixed soon, that's such a vital thing to be able to do.. |
|
@Def-Try I compared to the original and I think it's relatively the same now, could you check~ |
|
Btw, do you have a test level / world ? |
|
Hold - broken, while enabled using stamina to float, does not depend on the walls |
|
So do you have a test map? |
|
I do not |
|
Debugging ES5 / Rhino code sure isn't fun~ How is there not an up-to-date java implementation of ecmascript?? |
|
@Def-Try I commited the next refactoring step with the problem I can't seem to get fixed, maybe you know how to.. Basically since it's awful ES5 codes and I wanted to isolate your code as much as possible, like you would do with ES6, I wrapped them in 'module' syntax where needed. However, for some reason (as can be seen in the console) the interface global instance is just an empty object. |
|
Any updates on problem? I dunno what to do with this, maybe copy interface code to ui module? |
|
It seems the global object isn't readable. |
|
Btw, how was the jumping supposed to work since the spacebar is also the pause button? |
|
mod was actually started on server as simple js script, so we didnt have pause problem. Anyways, player can just host server and pause will can not be enabled |
|
That should probably be mentioned somewhere.. |
|
yes.. |
|
So it is a server-only mod? For some reason the ClientLoadEvent isn't triggered.. |
|
it started as server-only mod, but now it's not server only |
|
So it would be appropriate to split up the code into server-side / client-side.. |
This is currently only a draft PR as I'd like you to review #5 first.
General code refactoring
Fixed flying unit crash
Fixed various logic, .. bugs