Skip to content

Commit

Permalink
Revert "Replace numpy.amin with numpy.min for 1.25"
Browse files Browse the repository at this point in the history
This reverts commit 1a1c7c1.

Reverted as this should not be required, as per discussion on
https://github.com/numba/numba/pull/9011/files#r1261153152
  • Loading branch information
gmarkall committed Jul 28, 2023
1 parent 0c086cf commit 0ba4460
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions numba/tests/test_parfors.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
from numba.core.extending import register_jitable
from numba.core.bytecode import _fix_LOAD_GLOBAL_arg
from numba.core import utils
from numba.np.numpy_support import numpy_version

import cmath
import unittest
Expand Down Expand Up @@ -1422,14 +1421,9 @@ def test_impl(A):
# this doesn't fuse due to mixed indices
self.assertEqual(countParfors(test_impl, (numba.float64[:,:],)), 2)

if numpy_version < (1, 25):
def test_impl(A):
min_val = np.amin(A)
return A - min_val
else:
def test_impl(A):
min_val = np.min(A)
return A - min_val
def test_impl(A):
min_val = np.amin(A)
return A - min_val
self.check(test_impl, A)
# this doesn't fuse due to use of reduction variable
self.assertEqual(countParfors(test_impl, (numba.float64[:],)), 2)
Expand Down

0 comments on commit 0ba4460

Please sign in to comment.