-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive stepper #307
Open
danvau98
wants to merge
11
commits into
DedalusProject:master
Choose a base branch
from
danvau98:Adaptive_stepper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adaptive stepper #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to find some lower-order embedded methods that would increase the speed of these solvers. The Kennedy and Carpenter schemes are 4th and 5th-order; ideally, I should find a 3rd and 2nd-order scheme to add. |
if i == self.stages-1: | ||
# Swap the last row of H with b_hat | ||
H[-1, :] = b_hat_IM | ||
# A[-1, :] = b_hat_EX <- not sure if this is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting. I have a few questions:
- Did you check that you get the desired order of accuracy for both methods? I understand that you cannot just sum because of algebraic constraints. But if you solve, you are doing something different. If you get the correct order, is it by chance or is it expected?
- Why did you comment out the above line? I would expect that it is needed in general.
- How many more factorisations do you need with this scheme? The RK methods so far implemented in Dedalus are all singly diagonally implicit, such that you need only one factorisation per step. But I assume $\hat{b}s \neq H{ss}$, such that you need one more factorisation. If the step size is kept constant, do you need to factorize twice again in the next step or is there a cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional IMEX scheme with an embedded scheme to allow for adaptive stepping.