Draft
Conversation
Co-authored-by: DavidHuber-NOAA <[email protected]>
Co-authored-by: DavidHuber-NOAA <[email protected]>
Copilot
AI
changed the title
[WIP] Add new features to generate_workflows.sh
Add new features to generate_workflows.sh
Jul 1, 2025
Co-authored-by: DavidHuber-NOAA <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the
generate_workflows.shscript with several new features and improvements to provide better usability and flexibility for workflow generation.Key Changes
Required Features
-A(account) option required: The script now validates that an HPC account is provided and fails with a clear error message if missing-B/--build-computeoption allows usingbuild_compute.shinstead ofbuild_all.shfor compute node builds-L/--skip-linkoption allows skipping thelink_workflow.shstep when it's not neededMajor Enhancement
Long Options Added
All options now support descriptive long forms:
--account(required HPC account)--build-compute(use build_compute.sh)--skip-link(skip link_workflow.sh)--delete(auto-delete directories)--gfs,--gefs,--sfs,--gcafs(test type selection)--yaml,--yaml-dir(YAML configuration)--verbose,--very-verbose,--debug(output control)Usage Examples
Before (still supported):
Now also supports:
Backward Compatibility
All existing short options continue to work exactly as before. The only breaking change is the requirement for the
-Aaccount option, which improves error detection and user experience.Testing
Note: GCAFS support was already implemented in the existing code with the
-C/--gcafsoption and proper build flags.Fixes #24.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.