ci(sprint-19b): scope api port env for e2e workflow#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint 19B.4 — Fix del puerto de la Web en el workflow E2E manual
Resumen
Corrige el workflow manual
JobIT E2E (manual)para quePORT=4000solo aplique alarranque de la API y no sea heredado por
next start.Causa raíz
La primera ejecución manual del workflow (run 28959177676) falló en "Esperar web": la Web
heredó
PORT=4000del entorno global del job,next startrespetó esa variable e intentóescuchar en
:4000, ya ocupado por la API (EADDRINUSE). En local nunca ocurrió porquePORTvive solo enapps/api/.env.Cambio
PORT: 4000delenvglobal del job.PORT: 4000solo al stepArrancar API en background(junto aNODE_ENV: production, scopeada por el mismo motivo).envpara documentar ambas exclusiones.Verificaciones
workflow_dispatch.PORT: 4000aparece exactamente una vez, en el step de la API.git diff --check→ OK. Un solo archivo, +7/−4.JobIT CI.Fuera de alcance respetado
package.json/lockfile, branch protection,triggers ni deploy. Sin E2E como required check.
Revisión
PR lista para revisión humana. No mergear por CLI. Tras el merge: relanzar
gh workflow run e2e.yml --ref devpara la validación completa del stack.