added new printing output type value with print pdf method #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavBfr
reviewed
Jul 5, 2024
printing/ios/Classes/PrintJob.swift
Outdated
| let bestPaper = UIPrintPaper.bestPaper(forPageSize: currentSize!, withPapersFrom: paperList) | ||
|
|
||
| print("Use best paper: \(bestPaper.paperSize.width)x\(bestPaper.paperSize.height)") |
|
I thinbk it's missing some layoutPdf implementations for tests and web |
|
yes should be fixed now |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the printing package doesn't handle the print output type (only iOS side). This value allows to retrieve different paper list from the paper supported by the printer. Previously with .generic sett it couldn't be possible to use for example format like 4x6inches.
Additionally this PR include a new logic to select the paper from the
printInteractionControllermethod because it happens that theUIPrintPaper.bestPaperchoose a wrong paper size even if it is available in the supported list.