-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NewPage with freeSpace extended #1648 #1653
Conversation
What would be the reason to have newPageNeeded in the toplevel Widget? |
I chose the generic way in the base class Widget so that other widgets can also control the space requirement or a page break. |
But for backward compatibility, if someone created a method with this name it will break their app. |
I think the risk is low and would be easy to fix for the developer concerned. I believe the new options for other and new widgets are more important. But your are the owner, you can decide... |
What can I do that all checks can be completed successfully and this PR can be merged? |
I'll fix that. |
Merged. |
New parameter 'freeSpace' to the existing widget NewPage added, so that the page break is only executed if the free space is less than specified.
The default value of the new double parameter is Null, so that in this case a page break is always generated as before.
This PR solves the issue #1648.