Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct use of Flutter 3.19's ViewConfiguration constructor #1604

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix: correct use of Flutter 3.19's ViewConfiguration constructor #1604

merged 1 commit into from
Feb 21, 2024

Conversation

adil192
Copy link
Contributor

@adil192 adil192 commented Feb 16, 2024

Fixes #1603

Copy link

@rabeehlive rabeehlive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLEASE APPROVE THIS

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19d9f4b) 36.25% compared to head (e601174) 36.25%.
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1604   +/-   ##
=======================================
  Coverage   36.25%   36.25%           
=======================================
  Files         140      140           
  Lines       21727    21727           
=======================================
  Hits         7878     7878           
  Misses      13849    13849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavBfr DavBfr merged commit e601174 into DavBfr:master Feb 21, 2024
5 of 8 checks passed
@adil192 adil192 deleted the fix-flutter-3.19 branch February 26, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter 3.19 support
4 participants