Skip to content

first draft of adding graduates data endpoint #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

first draft of adding graduates data endpoint #80

wants to merge 5 commits into from

Conversation

nilarte
Copy link

@nilarte nilarte commented Feb 23, 2025

No description provided.

@nilarte
Copy link
Author

nilarte commented Feb 23, 2025

I have not tested this with actual graduates data yet.
That's a next step to be done.
Still please check we are on right path.
@alexeygrigorev

alexeygrigorev
alexeygrigorev reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@alexeygrigorev alexeygrigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. We also need to add tests and add some fake profiles so this endpoint actually returns something

alexeygrigorev
alexeygrigorev reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@alexeygrigorev alexeygrigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot - amazing work! just need to create tests =)

alexeygrigorev
alexeygrigorev reviewed Mar 17, 2025
View reviewed changes
courses/views/data.py
})


return JsonResponse(results, safe=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way, why safe=False?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeygrigorev alexeygrigorev alexeygrigorev left review comments

@nilarte-calsoft nilarte-calsoft nilarte-calsoft left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilarte @alexeygrigorev @nilarte-calsoft