Added new plugin multi_navigation_pagination.js #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome - thanks. Are you happy for this to be included under the MIT license? Also it looks like you actually have the jPaginator plug-in inline with your code. Is that intentional? |
|
Hi Allan,
I am not an expert and started with frontend technologies just few months
back. I have implemented this plugin for a requirement and wish to share
this with you as I was not able to find such plugin.
Regarding keeping JPaginator code. It is not intentional. Just to encounter
few bugs I kept JPaginator plugin inline.
Thankyou.
Regards,
Manjul Srivastava.
…On Mon 17 Dec, 2018, 6:32 PM Allan Jardine ***@***.*** wrote:
Awesome - thanks. Are you happy for this to be included under the MIT
license?
Also it looks like you actually have the jPaginator plug-in inline with
your code. Is that intentional?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#412 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG3HoHs4vvJKoK4-m1ZBc68AZjkt7K5wks5u55XOgaJpZM4ZWSWw>
.
|
|
Super - thanks. I'll not pull the PR in right now then, but will do so once I get a chance to review it properly and make any changes required. Thanks for much for sending it over. Could you confirm if you are happy with this being included under the MIT license please? |
|
Hi Allan,
Great thanks.
Once you review and feel this plug-in meets all quality standards for being
included under the MIT Licence you can consider it to include under MIT
Licence. I'll be happy with that.
Thankyou again for taking out time to consider my first initiative towards
open-source contribution.
Regards,
Manjul Srivastava
…On Mon 17 Dec, 2018, 8:30 PM Allan Jardine ***@***.*** wrote:
Super - thanks. I'll not pull the PR in right now then, but will do so
once I get a chance to review it properly and make any changes required.
Thanks for much for sending it over.
Could you confirm if you are happy with this being included under the MIT
license please?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#412 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG3HoJvwLXfiZIz74w8JlvhRh9wLkQ_0ks5u57F2gaJpZM4ZWSWw>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It provide multiple and convenient pagination options with optimal space utilization on view page. It has first, previous, page number drop-down, next and last page navigation options. I took references from multiple pagination plugins and JPaginatorto make more function rich pagination plugin