Spelling#331
Conversation
| <signature>any()</signature> | ||
| <description>Get a boolean value to indicate if there are any entries in the API instance's result set (i.e. any data, selected rows, etc).</description> | ||
| <returns type="boolean">`true` if there there is one or more items in the result set, `false` otherwise.</returns> | ||
| <returns type="boolean">`true` if there are one or more items in the result set, `false` otherwise.</returns> |
There was a problem hiding this comment.
atypical correction...
| * `string` - As a string, a single child row is create and the data is inserted into a single cell in that child row. | ||
| * `node` - As a `dt-tag tr` element, the `dt-tag tr` element is used as the child row. This can be useful it you wish to define multiple columns in the child row. | ||
| * `jQuery` - A jQuery object with nodes to be added. If there are multiple elements in the jQuery result set, they are added as multiple rows. If the node is `dt-tag tr` element it is treated a the child row, otherwise a row and cell are automatically created and the node from the jQuery result set inserted into it. | ||
| * `jQuery` - A jQuery object with nodes to be added. If there are multiple elements in the jQuery result set, they are added as multiple rows. If the node is `dt-tag tr` element it is treated as the child row, otherwise a row and cell are automatically created and the node from the jQuery result set inserted into it. |
There was a problem hiding this comment.
Atypical correction, the rule is against a+the (generally I don't check 1-2 letter words)
| * Use the DOM source to create up an array of header cells. The idea here is to | ||
| * create a layout grid (array) of rows x columns, which contains a reference | ||
| * to the cell that that point in the grid (regardless of col/rowspan), such that | ||
| * to the cell at that point in the grid (regardless of col/rowspan), such that |
| // listening for | ||
| $(settings.nTable).on( 'order.dt.DT column-visibility.dt.DT', function ( e, ctx ) { | ||
| if ( settings !== ctx ) { // need to check this this is the host | ||
| if ( settings !== ctx ) { // need to check if this is the host |
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
AllanJard
left a comment
There was a problem hiding this comment.
This should be diacritic rather than the original or the proposed replacement.
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
|
Thanks @AllanJard. Updated. |
|
This is an amazing PR - thank you for helping to improve the documentation and I'm sorry it has taken me so long to review it. I've looked though them all now and I think it is just that Have you got some custom software you are using for this sort of spelling review? There are a number of changes there that aren't just simple search and replace... |
|
❤️ I don't see a review comment about I imagine you're asking about 139f586 DataTablesSrc/js/api/api.base.js Lines 405 to 410 in 139f586 Note that this file already had instances of DataTablesSrc/js/api/api.base.js Lines 426 to 446 in 139f586
For the review, yes, the tooling is basically: Corrections are all manual, although I do have some extra tooling for search+replacing. I iterate through the fix process Other projects use the software, and I'm happy to help if you're interested in using it. |
|
Its really impressive - thank you! It's great to have these fixed en mass and to improve the quality of the documentation! I will look at using the bot on my repos :) |
No description provided.