Skip to content

refactor: Rationalize SQL dialect and statement code, to simplify adding new dialects - #2235

Merged
ferenc-csaky merged 2 commits into
mainfrom
refactor/sql-dialects
Jul 29, 2026
Merged

refactor: Rationalize SQL dialect and statement code, to simplify adding new dialects#2235
ferenc-csaky merged 2 commits into
mainfrom
refactor/sql-dialects

update snapshots

e589ac2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 27, 2026 in 1s

17.10% (+0.18%) compared to 98a02a8

View this Pull Request on Codecov

17.10% (+0.18%) compared to 98a02a8

Details

Codecov Report

❌ Patch coverage is 31.08108% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.10%. Comparing base (98a02a8) to head (e589ac2).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sqrl/calcite/dialect/SqlTranslationDispatcher.java 0.00% 17 Missing ⚠️
...atasqrl/calcite/convert/AbstractSqlConverters.java 7.14% 13 Missing ⚠️
...abase/relational/AbstractJdbcStatementFactory.java 0.00% 8 Missing ⚠️
...tasqrl/calcite/convert/SnowflakeSqlConverters.java 50.00% 2 Missing ⚠️
...tasqrl/calcite/dialect/BasePostgresSqlDialect.java 0.00% 2 Missing ⚠️
...database/relational/SnowflakeStatementFactory.java 0.00% 2 Missing ⚠️
.../java/com/datasqrl/calcite/SqrlConfigurations.java 0.00% 1 Missing ⚠️
...m/datasqrl/calcite/convert/FlinkSqlConverters.java 50.00% 1 Missing ⚠️
...com/datasqrl/calcite/dialect/DuckDbSqlDialect.java 83.33% 1 Missing ⚠️
...rl/calcite/dialect/ExtendedPostgresSqlDialect.java 87.50% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2235      +/-   ##
============================================
+ Coverage     16.91%   17.10%   +0.18%     
- Complexity     1040     1045       +5     
============================================
  Files           613      611       -2     
  Lines         17738    17693      -45     
  Branches       2155     2155              
============================================
+ Hits           3001     3026      +25     
+ Misses        14425    14355      -70     
  Partials        312      312

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

View more details on Codecov