COALESCE selected expressions to capture all values
#1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For metrics SQL generation, we should
COALESCEthe selected expressions after doing aFULL OUTER JOINon the shared dimensions of the metrics. This is because the intention of theFULL JOINis to be able to bring in all possible dimension values, and not coalescing means that we miss out on cases with null values for one set of metrics, but non-null values for a different set of metrics.Test Plan
Locally + unit tests
COALESCEdimensions after doing theFULL JOIN#1204make checkpassesmake testshows 100% unit test coverageDeployment Plan