Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For metrics SQL generation, we should COALESCE dimensions after doing the FULL JOIN #1204

Open
shangyian opened this issue Oct 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@shangyian
Copy link
Contributor

When we generate metrics SQL, we group the metrics by their parent transforms, generate the aggregate SQL per transform, and then merge the the transforms together using a FULL JOIN to make sure we capture all dimensions. However, we need to COALESCE to fully capture all dimension values.

@shangyian shangyian added the bug Something isn't working label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant