fix(CI): add checksum of the added binary for more safety #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouquette
reviewed
Feb 19, 2024
Dockerfile
Outdated
| @@ -7,6 +7,7 @@ ENV GO_VERSION=1.21.5 | |||
| ENV GO_SHA=e2bc0b3e4b64111ec117295c088bde5f00eeed1567999ff77bc859d7df70078e | |||
| ENV HELM_VERSION=3.12.3 | |||
| ENV HELM_SHA=1b2313cd198d45eab00cc37c38f6b1ca0a948ba279c29e322bdf426d406129b5 | |||
| ENV CI_UPLOADER_SHA=873976f0f8de1073235cf558ea12c7b922b28e1be22dc1553bf56162beebf09d | |||
There was a problem hiding this comment.
Not blocking, but I think this would be better suited to be an ARG, as we don't need the variable to be available while running the container
There was a problem hiding this comment.
I wanted to fit with the above, some of the declared ENV might be ARG as well I guess.
Updated, thanks
chouquette
approved these changes
Feb 19, 2024
chouetz
force-pushed
the
nschweitzer/APL-2673/checksum
branch
from
967b1e6 to
7c5de11
Compare
chouetz
force-pushed
the
nschweitzer/APL-2673/checksum
branch
from
7c5de11 to
2d4be5d
Compare
spencergilbert
approved these changes
Feb 21, 2024
KevinFairise2
approved these changes
Feb 22, 2024
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 13m) Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Complement #627 with a security verification
Which scenarios this will impact?
n/a
Motivation
security
Additional Notes