Create interface for parameter cross cloud providers

common/config/environment.go

@@ -59,8 +59,9 @@ const (
 type CommonEnvironment struct {
 	providerRegistry
 
-	Ctx         *pulumi.Context
-	CommonNamer namer.Namer
+	Ctx                      *pulumi.Context
+	CommonNamer              namer.Namer
+	CloudProviderEnvironment CloudProviderEnvironment
 
 	InfraConfig           *sdkconfig.Config
 	AgentConfig           *sdkconfig.Config
@@ -71,16 +72,21 @@ type CommonEnvironment struct {
 	username string
 }
 
-func NewCommonEnvironment(ctx *pulumi.Context) (CommonEnvironment, error) {
+type CloudProviderEnvironment interface {
+	GetInternalRegistry() string
+}
+
+func NewCommonEnvironment(ctx *pulumi.Context, cloudProviderEnvironment CloudProviderEnvironment) (CommonEnvironment, error) {
 	env := CommonEnvironment{
-		Ctx:                   ctx,
-		InfraConfig:           sdkconfig.New(ctx, DDInfraConfigNamespace),
-		AgentConfig:           sdkconfig.New(ctx, DDAgentConfigNamespace),
-		TestingWorkloadConfig: sdkconfig.New(ctx, DDTestingWorkloadNamespace),
-		DogstatsdConfig:       sdkconfig.New(ctx, DDDogstatsdNamespace),
-		UpdaterConfig:         sdkconfig.New(ctx, DDUpdaterConfigNamespace),
-		CommonNamer:           namer.NewNamer(ctx, ""),
-		providerRegistry:      newProviderRegistry(ctx),
+		Ctx:                      ctx,
+		InfraConfig:              sdkconfig.New(ctx, DDInfraConfigNamespace),
+		AgentConfig:              sdkconfig.New(ctx, DDAgentConfigNamespace),
+		TestingWorkloadConfig:    sdkconfig.New(ctx, DDTestingWorkloadNamespace),
+		DogstatsdConfig:          sdkconfig.New(ctx, DDDogstatsdNamespace),
+		UpdaterConfig:            sdkconfig.New(ctx, DDUpdaterConfigNamespace),
+		CommonNamer:              namer.NewNamer(ctx, ""),
+		CloudProviderEnvironment: cloudProviderEnvironment,
+		providerRegistry:         newProviderRegistry(ctx),
 	}
 	// store username
 	user, err := user.Current()

resources/aws/environment.go

@@ -62,9 +62,16 @@ type Environment struct {
 	randomSubnets pulumi.StringArrayOutput
 }
 
+type CloudProviderEnvironment struct{}
+
+func (e *CloudProviderEnvironment) GetInternalRegistry() string {
+	return "669783387624.dkr.ecr.us-east-1.amazonaws.com"
+}
+
 func WithCommonEnvironment(e *config.CommonEnvironment) func(*Environment) {
 	return func(awsEnv *Environment) {
 		awsEnv.CommonEnvironment = e
+		awsEnv.CommonEnvironment.CloudProviderEnvironment = &CloudProviderEnvironment{}
 	}
 }
 
@@ -77,8 +84,10 @@ func NewEnvironment(ctx *pulumi.Context, options ...func(*Environment)) (Environ
 	for _, opt := range options {
 		opt(&env)
 	}
+
+	awsParameter := &CloudProviderEnvironment{}
 	if env.CommonEnvironment == nil {
-		commonEnv, err := config.NewCommonEnvironment(ctx)
+		commonEnv, err := config.NewCommonEnvironment(ctx, awsParameter)
 		if err != nil {
 			return Environment{}, err
 		}

resources/azure/environment.go

@@ -33,8 +33,16 @@ type Environment struct {
 	envDefault environmentDefault
 }
 
+type CloudProviderEnvironment struct{}
+
+func (p *CloudProviderEnvironment) GetInternalRegistry() string {
+	return ""
+}
+
 func NewEnvironment(ctx *pulumi.Context) (Environment, error) {
-	commonEnv, err := config.NewCommonEnvironment(ctx)
+
+	azureParameter := &CloudProviderEnvironment{}
+	commonEnv, err := config.NewCommonEnvironment(ctx, azureParameter)
 	if err != nil {
 		return Environment{}, err
 	}

resources/hyperv/environment.go

@@ -23,8 +23,15 @@ type Environment struct {
 	Namer namer.Namer
 }
 
+type CloudProviderEnvironment struct{}
+
+func (p *CloudProviderEnvironment) GetInternalRegistry() string {
+	return ""
+}
+
 func NewEnvironment(ctx *pulumi.Context) (Environment, error) {
-	commonEnv, err := config.NewCommonEnvironment(ctx)
+	hyperVParameter := &CloudProviderEnvironment{}
+	commonEnv, err := config.NewCommonEnvironment(ctx, hyperVParameter)
 	if err != nil {
 		return Environment{}, err
 	}

scenarios/aws/microVMs/microvms/run.go

@@ -372,7 +372,7 @@ func RunAndReturnInstances(e commonConfig.CommonEnvironment) (*ScenarioDone, err
 }
 
 func Run(ctx *pulumi.Context) error {
-	commonEnv, err := commonConfig.NewCommonEnvironment(ctx)
+	commonEnv, err := commonConfig.NewCommonEnvironment(ctx, nil)
 	if err != nil {
 		return err
 	}