Move internal registry reference to scenario to avoid loosing abstraction in component #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion in component
pducolin
approved these changes
Feb 16, 2024
| @@ -32,7 +31,7 @@ import ( | |||
| // [Functional options pattern]: https://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis | |||
|
|
|||
| type Params struct { | |||
| // FullImagePath is the full path of the docker agent image to use. | |||
| // AgentFullImagePath is the full path of the docker agent image to use. | |||
| // It has priority over ImageTag and Repository. | |||
| FullImagePath string | |||
There was a problem hiding this comment.
❓ question
Should you change the param name too ?
| @@ -27,7 +27,7 @@ type K8sComponent struct { | |||
| pulumi.ResourceState | |||
| } | |||
|
|
|||
| func K8sAppDefinition(e config.CommonEnvironment, kubeProvider *kubernetes.Provider, namespace string, fakeIntake *fakeintake.Fakeintake, kubeletTLSVerify bool, clusterName string, opts ...pulumi.ResourceOption) (*K8sComponent, error) { | |||
| func K8sAppDefinition(e config.CommonEnvironment, kubeProvider *kubernetes.Provider, namespace string, fakeIntake *fakeintake.Fakeintake, kubeletTLSVerify bool, clusterName string, fullImagePath string, opts ...pulumi.ResourceOption) (*K8sComponent, error) { | |||
There was a problem hiding this comment.
💭 thought
Not related to this PR, wonder if we should move the long signature to a struct defining all params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Partially revert #602 and make some changes to be able to make existing scenari use the image built in the CI when pipeline ID and commit SHA are defined
Which scenarios this will impact?
docker, kind, eks
Motivation
Avoid loosing the abstraction on components. Components should not be coupled with Cloud Provider
Additional Notes