-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APL-2847 Create KubernetesAgent component to install the agent in Kubernetes #618
Conversation
192cd9d
to
1bb2494
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !!
return components.Export(ctx, h, out) | ||
} | ||
|
||
func NewKubernetesAgent(e config.CommonEnvironment, clusterName string, kubeProvider *kubernetes.Provider, options ...kubernetesagentparams.Option) (*KubernetesAgent, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question
Could this be used in the eks run function at https://github.com/DataDog/test-infra-definitions/blob/nplanel/fix-docker-publish/scenarios/aws/eks/run.go#L217-L236 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be used in this run function. However I think it is easier to use it with a Provider (for example) that will automatically register the output. So you do not need to add explicit export to the Pulumi stack like that:
ctx.Export("agent-linux-helm-install-name", helmComponent.LinuxHelmReleaseName)
ctx.Export("agent-linux-helm-install-status", helmComponent.LinuxHelmReleaseStatus)
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 13m) Use |
/merge -c |
This merge request build was cancelled If you need support, contact us on Slack #ci-interfaces! |
Co-authored-by: Vincent Boulineau <[email protected]>
…-infra-definitions into kfairise/kindvm-provisioner
322c04a
to
b5820c8
Compare
Co-authored-by: Vincent Boulineau <[email protected]>
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 14m) Use |
What does this PR do?
Create KubernetesAgent component to install the agent on Kubernetes with Helm
Which scenarios this will impact?
Motivation
Give a component to install the Agent in Kubernetes for the KindVM provider
Additional Notes