Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APL-2847 Create KubernetesAgent component to install the agent in Kubernetes #618

Merged
merged 16 commits into from
Feb 21, 2024

Conversation

KevinFairise2
Copy link
Member

@KevinFairise2 KevinFairise2 commented Feb 12, 2024

What does this PR do?

Create KubernetesAgent component to install the agent on Kubernetes with Helm

Which scenarios this will impact?

Motivation

Give a component to install the Agent in Kubernetes for the KindVM provider

Additional Notes

@KevinFairise2 KevinFairise2 force-pushed the kfairise/kindvm-provisioner branch from 192cd9d to 1bb2494 Compare February 13, 2024 13:45
@KevinFairise2 KevinFairise2 marked this pull request as ready for review February 13, 2024 13:48
@KevinFairise2 KevinFairise2 requested a review from a team as a code owner February 13, 2024 13:48
Copy link
Contributor

@pducolin pducolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !!

return components.Export(ctx, h, out)
}

func NewKubernetesAgent(e config.CommonEnvironment, clusterName string, kubeProvider *kubernetes.Provider, options ...kubernetesagentparams.Option) (*KubernetesAgent, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be used in this run function. However I think it is easier to use it with a Provider (for example) that will automatically register the output. So you do not need to add explicit export to the Pulumi stack like that:

ctx.Export("agent-linux-helm-install-name", helmComponent.LinuxHelmReleaseName)
ctx.Export("agent-linux-helm-install-status", helmComponent.LinuxHelmReleaseStatus)

components/datadog/agent/kubernetes.go Outdated Show resolved Hide resolved
@KevinFairise2 KevinFairise2 changed the title Create KubernetesAgent component to install the agent in Kubernetes APL-2847 Create KubernetesAgent component to install the agent in Kubernetes Feb 14, 2024
@KevinFairise2
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 15, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 13m)

Use /merge -c to cancel this operation!

@vboulineau
Copy link
Collaborator

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Feb 15, 2024

⚠️ MergeQueue

This merge request build was cancelled

If you need support, contact us on Slack #ci-interfaces!

components/datadog/agent/kubernetes.go Outdated Show resolved Hide resolved
components/datadog/agent/kubernetes.go Outdated Show resolved Hide resolved
components/datadog/agent/kubernetes.go Outdated Show resolved Hide resolved
components/datadog/kubernetesagentparams/params.go Outdated Show resolved Hide resolved
components/datadog/kubernetesagentparams/params.go Outdated Show resolved Hide resolved
components/datadog/kubernetesagentparams/params.go Outdated Show resolved Hide resolved
@KevinFairise2 KevinFairise2 force-pushed the kfairise/kindvm-provisioner branch from 322c04a to b5820c8 Compare February 20, 2024 10:18
@KevinFairise2
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 21, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 14m)

Use /merge -c to cancel this operation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants