Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missing dependency between VPA CRD and CR #1301

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Dec 16, 2024

What does this PR do?

Add an explicit dependency between the pulumi resource that creates the VPA CRD and the ones that create VPA CR.

Which scenarios this will impact?

  • aws/eks
  • aws/kind

Motivation

Avoid possible race conditions where pulumi would try to create a VPA resource before the definition, leading to errors like:

Diagnostics:
  kubernetes:autoscaling.k8s.io/v1beta2:VerticalPodAutoscaler (redis):
    error: creation of resource "urn:pulumi:ci-737239415-4670-orch-kind-cluster::e2eci::pulumi:providers:kubernetes$dd:apps$kubernetes:autoscaling.k8s.io/v1beta2:VerticalPodAutoscaler::redis" with kind autoscaling.k8s.io/v1beta2/VerticalPodAutoscaler failed because the Kubernetes API server reported that the apiVersion for this resource does not exist. Verify that any required CRDs have been created: no matches for kind "VerticalPodAutoscaler" in version "autoscaling.k8s.io/v1beta2"

Additional Notes

@L3n41c L3n41c requested a review from a team as a code owner December 16, 2024 14:17
@L3n41c
Copy link
Member Author

L3n41c commented Dec 17, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 17, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-17 11:03:56 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 2m.


2024-12-17 11:05:12 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 4b4112f into main Dec 17, 2024
10 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lenaic/fix_vpa branch December 17, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants