[ADXT-783] Made Runner interface for Remote and Local runners

[CelianR]

What does this PR do?

Did an interface that gathers remote and local runners.

Notes

• microvm/runner file has been removed since it is useless now
• The environment is passed additionally to commands, otherwise there is no shell expansion to variables we define in the arguments
• MoveRemoteFile command has been updated since ' were not escaping the file paths, changed to double quotes
• A second PR will come to refactor filemanager functions and command.Args
• Datadog agent pipeline

Which scenarios this will impact?

Motivation

Additional Notes

• Tested with local podman example

[pducolin]

💬 suggestion
For this, you could have a LocalArguments interface, that only a new struct LocalArgs implement, and cast Args to LocalArgs here, failing if the cast fails.

This would be something like

type Args struct {
	Create                   pulumi.StringInput
	Update                   pulumi.StringInput
	Delete                   pulumi.StringInput
	Triggers                 pulumi.ArrayInput
	Stdin                    pulumi.StringPtrInput
	Environment              pulumi.StringMap
	RequirePasswordFromStdin bool
	Sudo                     bool
}

type LocalArguments interface {
	LocalAssetPaths() pulumi.StringArrayInput
	LocalDir() 		       pulumi.StringInput
}

type LocalArgs struct {
	Args
	LocalAssetPaths pulumi.StringArrayInput
	LocalDir        pulumi.StringInput  
}

var _ LocalArgument = *LocalArgs{}

func (args *LocalArgs) LocalAssetPaths() pulumi.StringArrayInput {
	return args.LocalAssetPaths
}

func (args *LocalArgs) LocalDir() pulumi.StringInput {
	return args.LocalDir
}

func (args *Args) toLocalCommandArgs(config RunnerConfiguration, osCommand OSCommand) (*local.CommandArgs, error) {
	if localArgs, ok := args.(LocalArgs); !ok {
		return nil, fmt.Errorf("can convert only local args")
	} 
	return &local.CommandArgs{
		Create:   osCommand.Build
		Create:      osCommand.BuildCommandString(args.Create, args.Environment, args.Sudo, args.RequirePasswordFromStdin, config.user),
		Update:      osCommand.BuildCommandString(args.Update, args.Environment, args.Sudo, args.RequirePasswordFromStdin, config.user),
		Delete:      osCommand.BuildCommandString(args.Delete, args.Environment, args.Sudo, args.RequirePasswordFromStdin, config.user),
		Environment: args.Environment,
		Triggers:    args.Triggers,
		Stdin:       args.Stdin,
		AssetPaths:  localArgs.LocalAssetPaths,
		Dir:         localArgs.LocalDir,
	}, nil
}

Don't know if you can possibly define toLocalCommandArgs on LocalArgs rather than on Args, I think you showed me yesterday you could not

[pducolin]

Passing all tests in datadog-agent DataDog/datadog-agent#32459

[pducolin]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-26 09:39:38 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 3m.

---

2024-12-26 09:41:51 UTC ℹ️ MergeQueue: This merge request was merged