[resource_datadog_custom_allocation_rules] add the functionality to allow users decide custom allocation rule reorder behaviors #3324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congx4
changed the title
congx4
changed the title
michaelcretzman
approved these changes
Nov 17, 2025
rtrieu
approved these changes
Nov 18, 2025
Contributor
rtrieu
left a comment
rtrieu
left a comment
There was a problem hiding this comment.
left some minor suggestions, but they are non-blocking!
Co-authored-by: Rosa Trieu <[email protected]>
Co-authored-by: Rosa Trieu <[email protected]>
Co-authored-by: Rosa Trieu <[email protected]>
alextmeyer
approved these changes
Nov 20, 2025
amarshall-dd
approved these changes
Nov 20, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the functionality to allow users define the custom allocation rule reorder behaviors:
when override_ui_defined_resources is false:
If there are rules in middle of existing rules that are managed by terraform, during plan and apply phase, we error it.
If there are rules at the end of existing rules, during plan and apply phase, we warn about unmanaged rules detected at the end of order.
when override_ui_defined_resources is true:
Whenever they are some UI-defined rules, during plan phase, we warn about UI-defined rules will be deleted. During apply phase, we actually delete any UI-defined rules.
Tested in us5 region, all scenarios are aligned with expected results.