-
Notifications
You must be signed in to change notification settings - Fork 14
Add language-specific linting and shellcheck to format.sh #5689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came from running npm install; npm ci would fail otherwise
| local e | ||
| for e; do [[ "${e}" == "${needle}" ]] && return 0; done | ||
|
|
||
| # shellcheck disable=SC2053 # explicitly allow glob matching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed glob matching to ignore *node_modules*, otherwise this fails locally if you've installed any of them before
|
Test failure are unrelated - going to bypass merge |
Motivation
#5684 failed linting in CI, although
format.shpassed locallyChanges
This PR introduces npm checks (when installed) and shellcheck into
format.shto more easily identify these issues before a PR is openedWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present