Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECI-395 Search Resources for Logging #24
ECI-395 Search Resources for Logging #24
Changes from all commits
f18ea00
e29b294
fcf68c9
e18b960
3eb865b
ef81ad9
d519333
06fdbfb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if "service_id" or "service_name"? might be a better name for this? I see "group_id" as an OCI Group's OCID (eg.
DatadogAuthGroup
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of this variable is to specify
Unique Name for the group of resource types
. It doesn't really have to be associated to a service id. The purpose here is to provide any string (it may not even be a service id).This ensures that the abstraction for any caller code to use
resourcediscovery
module is as simple as possible (all you need to provide is compartment ocid and list of resource types).