8318113: CSS.BackgroundImage doesn't implement equals

Reviewed-by: aivanov, tr, prr
DataDog · Nov 27, 2023 · 1272368 · 1272368
1 parent 28d3762
commit 1272368
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/java.desktop/share/classes/javax/swing/text/html/CSS.java b/src/java.desktop/share/classes/javax/swing/text/html/CSS.java
@@ -2965,6 +2965,17 @@ ImageIcon getImage(URL base) {
             }
             return image;
         }
+
+        @Override
+        public int hashCode() {
+            return Objects.hashCode(svalue);
+        }
+
+        @Override
+        public boolean equals(Object val) {
+            return val instanceof CSS.BackgroundImage img
+                   && Objects.equals(svalue, img.svalue);
+        }
     }
 
     /**

diff --git a/test/jdk/javax/swing/text/html/CSS/CSSAttributeEqualityBug.java b/test/jdk/javax/swing/text/html/CSS/CSSAttributeEqualityBug.java
@@ -31,7 +31,7 @@
 
 /*
  * @test
- * @bug 7083187
+ * @bug 7083187 8318113
  * @summary  Verifies if CSS.CSSValue attribute is same
  * @run main CSSAttributeEqualityBug
  */
@@ -72,6 +72,9 @@ public class CSSAttributeEqualityBug {
             "background-position: 1em 2em",
 
             "border-width: medium",
+
+            "background-image: none",
+            "background-image: url(image.png)",
     };
 
     /**
@@ -86,6 +89,8 @@ public class CSSAttributeEqualityBug {
             {"margin-top: 42px", "margin-top: 22px"},
             {"margin-top: 42px", "margin-top: 42pt"},
             {"margin-top: 100%", "margin-top: 50%"},
+
+            {"background-image: none", "background-image: url(image.png)"},
     };
 
     private static final String[][] EQUALS_WITH_SPACE = {